Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus definitions for key metrics. #9088

Merged
merged 5 commits into from Nov 5, 2020

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Nov 2, 2020

Bumps go.md to the latest go-metrics to include the prometheus definitions patch and updates vendor. Also defines various key metrics for operating consul for their use in the beta in lib/telemetry.go.

Refs hashicorp/go-metrics#120

@mkcp mkcp requested a review from a team November 2, 2020 23:03
@github-actions github-actions bot added the theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics label Nov 2, 2020
@mikemorris mikemorris added this to the 1.9.0 milestone Nov 3, 2020
@mkcp mkcp modified the milestones: 1.9.0, 1.9.0-beta2 Nov 4, 2020
@mkcp mkcp marked this pull request as ready for review November 4, 2020 22:05
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fmt question but otherwise looks great.
🤙

@mkcp mkcp merged commit b3ecdcc into master Nov 5, 2020
@mkcp mkcp deleted the mkcp/telemetry/add-key-metrics-definitions branch November 5, 2020 20:20
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit b3ecdcc onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Nov 6, 2020
…s-definitions

Add prometheus definitions for key metrics.
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit b3ecdcc onto release/1.9.x failed! Build Log

@mikemorris
Copy link
Contributor

Added a changelog entry in #9129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants