Backport of Add custom balancer to always remove subConns into release/1.14.x #15836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/kisunji/patched-pick-first-balancer/intensely-lucky-tahr
branch
from
f527b23
to
a545684
Compare
github-team-consul-core-pr-approver
approved these changes
Dec 19, 2022
hc-github-team-consul-core
deleted the
backport/kisunji/patched-pick-first-balancer/intensely-lucky-tahr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15701 to be assessed for backporting due to the inclusion of the label backport/1.14.
The below text is copied from the body of the original PR.
Fixes #10603
Description
Remove the need to call
UpdateStatetwice by changing thepick_firstbalancer's behavior to close existing connections (almost) every time.Testing & Reproduction steps
No net-new behavior; existing test
TestClientConnPool_IntegrationWithGRPCResolver_Rebalanceis still passing.Manually tested with frequent rebalancing
PR Checklist
Overview of commits