Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Detect Vault 1.11+ import in secondary datacenters and update default issuer into release/1.13.x #15682

Conversation

hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Dec 5, 2022

Backport

This PR is auto-generated from #15661 to be assessed for backporting due to the inclusion of the label backport/1.13.

The below text is copied from the body of the original PR.


Description

The fix outlined and merged in #15253 fixed the issue as it occurs in the primary DC. There is a similar issue that arises when vault is used as the Connect CA in a secondary datacenter that is fixed by this PR.

Additionally: this PR adds support to run the existing suite of vault related integration tests against the last 4 versions of vualt (1.9, 1.10, 1.11, 1.12)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/fix-vault-ca-secondary-renewal/admittedly-open-cub branch 2 times, most recently from 41f7b49 to f39462d Compare December 5, 2022 21:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Dec 5, 2022
… issuer

The fix outlined and merged in #15253 fixed the issue as it occurs in the primary
DC. There is a similar issue that arises when vault is used as the Connect CA in a
secondary datacenter that is fixed by this PR.

Additionally: this PR adds support to run the existing suite of vault related integration
tests against the last 4 versions of vault (1.9, 1.10, 1.11, 1.12)
@rboyer rboyer force-pushed the backport/fix-vault-ca-secondary-renewal/admittedly-open-cub branch from f39462d to 3499d2d Compare December 5, 2022 21:53
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
consul ⬜️ Ignored (Inspect) Dec 5, 2022 at 9:54PM (UTC)
consul-ui-staging ⬜️ Ignored (Inspect) Dec 5, 2022 at 9:54PM (UTC)

@rboyer rboyer marked this pull request as ready for review December 5, 2022 21:54
@rboyer rboyer merged commit 8a7ac76 into release/1.13.x Dec 5, 2022
@rboyer rboyer deleted the backport/fix-vault-ca-secondary-renewal/admittedly-open-cub branch December 5, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants