Update hcp-scada-provider to fix diamond dependency problem with go-msgpack #15185
Conversation
github-actions
bot
added
the
pr/dependencies
| @@ -19,11 +19,11 @@ require ( | |||
| github.com/coredns/coredns v1.6.6 | |||
| github.com/coreos/go-oidc v2.1.0+incompatible | |||
| github.com/docker/go-connections v0.3.0 | |||
| github.com/envoyproxy/go-control-plane v0.10.1 | |||
| github.com/envoyproxy/go-control-plane v0.10.2-0.20220325020618-49ff273808a1 | |||
There was a problem hiding this comment.
@erichaberkorn do you know if this will be okay? A bunch of these are side effects from updating scada provider
There was a problem hiding this comment.
It theoretically should be fine 😂 I'm more concerned about the protobuf upgrade.
kisunji
added
the
pr/no-changelog
| @@ -132,8 +133,6 @@ func (c *ClientConnPool) dial(datacenter string, serverType string) (*grpc.Clien | |||
| grpc.WithContextDialer(c.dialer), | |||
| grpc.WithDisableRetry(), | |||
| grpc.WithStatsHandler(agentmiddleware.NewStatsHandler(metrics.Default(), metricsLabels)), | |||
| // nolint:staticcheck // there is no other supported alternative to WithBalancerName | |||
| grpc.WithBalancerName("pick_first"), | |||
There was a problem hiding this comment.
This method is gone from the API but "pick_first" was the default balancer anyways (source) so this should have no impact 🤞
| @@ -132,8 +133,6 @@ func (c *ClientConnPool) dial(datacenter string, serverType string) (*grpc.Clien | |||
| grpc.WithContextDialer(c.dialer), | |||
| grpc.WithDisableRetry(), | |||
| grpc.WithStatsHandler(agentmiddleware.NewStatsHandler(metrics.Default(), metricsLabels)), | |||
| // nolint:staticcheck // there is no other supported alternative to WithBalancerName | |||
| grpc.WithBalancerName("pick_first"), | |||
There was a problem hiding this comment.
How are you going to turn on the "pick the first server every time" behavior now?
There was a problem hiding this comment.
I believe "pick_first" is the default balancer.
If I'm wrong, then this should be the new way to define balancer config: weaveworks/common#239 (comment)
|
Does this need a 1.14 backport? |
No description provided.