Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds idle_timeout envoy proxy local app config knob #14418

Closed
wants to merge 2 commits into from

Conversation

johnalotoski
Copy link

Description

We require override of envoy's default stream_idle_timeout which we are unable to do via Nomad and escape hatches at this time AFAICT. This has also been asked for in the community. See refs below.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Aug 31, 2022
@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Oct 31, 2022
@aoskotsky-amplify
Copy link
Contributor

Could someone review this? I also need this. I have some services that are blocked by this because they need more than the default 5 minute timeout in envoy

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Nov 1, 2022
@rddimon
Copy link

rddimon commented Dec 2, 2022

@johnalotoski @aoskotsky-amplify This is already released in #14340

@david-yu
Copy link
Contributor

david-yu commented Dec 2, 2022

Thanks @rddimon . @johnalotoski This was indeed released in 1.14.2. Will close this PR. Thank you.

@david-yu david-yu closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants