update raft to v1.3.8 #12844
Merged
update raft to v1.3.8 #12844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr/dependencies
eculver
reviewed
Apr 22, 2022
.changelog/12844.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| raft: upgrade to v1.3.6 which fixes a bug where non cluster member can still be able to participate in an election. | |||
There was a problem hiding this comment.
good catch, I made a typo writing it
eculver
reviewed
Apr 22, 2022
.changelog/12844.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| raft: upgrade to v1.3.6 which fixes a bug where non cluster member can still be able to participate in an election. | |||
There was a problem hiding this comment.
Suggested change
| raft: upgrade to v1.3.6 which fixes a bug where non cluster member can still be able to participate in an election. | |
| raft: upgrade to v1.3.7 which fixes a bug where non cluster member can still be able to participate in an election. |
|
I'm curious, what are the implications of making these fields "reloadable"? (edit) I missed that part of the description. I'm now wondering if something needs to change in Consul to validate updates to these values? |
|
Also, it looks like |
mkeeler
approved these changes
Apr 22, 2022
mkeeler
approved these changes
Apr 25, 2022
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/650650. |
dhiaayachi
added a commit
that referenced
this pull request
Apr 25, 2022
* update raft to v1.3.7 * add changelog * fix compilation error * fix HeartbeatTimeout * fix ElectionTimeout to reload only if value is valid * fix default values for `ElectionTimeout` and `HeartbeatTimeout` * fix test defaults * bump raft to v1.3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update raft to v1.3.7
In this raft release
HeartbeatTimeoutandElectionTimeoutbecame reloadable config, so Consul needed to be tweaked to only reload those configs only when the given values are within the acceptable range.Note that this also introduce hashicorp/raft#477