Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add Vault as a Service External Source #10769

Merged
merged 5 commits into from Aug 4, 2021

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Aug 4, 2021

✨ Description:

Vault is now using the service external-source flag. Vault has always been supported as an external-source, but hasn't always used the flag.

The Registered in <external-source> is the Consul::ExternalSource component.

The %pill styling is used by Consul::ExternalSource.

Changes:

  • Added Vault logo to the code base
  • Added styling support for the vault logo
  • Added 'vault' to /service/external-source helper
  • Updates to mock-data
  • Added a Consul::ExternalSource README.mdx for documentation

Demo Link

📸 Screenshots:

You can now find Vault in...

  • Service list row

service_list_row

  • Service Instances list row

service_instances_row

  • At the top of the Service detail page

top_serivce_detail

  • At the top of the Service Instance page

top_service_instance

⚡ Backend Changes:

Vault team added supported in this Vault repo PR

🤡 Updates to mock-api:

Updated mock data for the following endpoints:

  • /health/service/
  • /internal/ui/gateway-services-nodes/
  • /internal/ui/service-topology/
  • /internal/ui/services

🧪 Testing:

No testing added.

  • Changelog
  • Demo Link

@kaxcode kaxcode added the theme/ui Anything related to the UI label Aug 4, 2021
@kaxcode kaxcode requested review from gsusmi and a user August 4, 2021 18:11
@vercel vercel bot temporarily deployed to Preview – consul August 4, 2021 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 4, 2021 18:13 Inactive
@gsusmi
Copy link

gsusmi commented Aug 4, 2021

@kaxcode , can you point me to a template that's populating pill class name? Trying to get a full picture. Ty!

@kaxcode
Copy link
Contributor Author

kaxcode commented Aug 4, 2021

@kaxcode , can you point me to a template that's populating pill class name? Trying to get a full picture. Ty!

@gsusmi
Yes, just updated the Description to link you to the component and the styling.

Copy link

@gsusmi gsusmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ty!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only feedback is that ['vault', 'kubernetes', 'terraform', 'nomad', 'consul', 'aws'] appears to be duplicated in a handful of places (in different orders). This smells like data and it might be useful to export from a single location, if feasible. Thoughts?

@kaxcode
Copy link
Contributor Author

kaxcode commented Aug 4, 2021

Looks good. My only feedback is that ['vault', 'kubernetes', 'terraform', 'nomad', 'consul', 'aws'] appears to be duplicated in a handful of places (in different orders). This smells like data and it might be useful to export from a single location, if feasible. Thoughts?

@randallmorey I agree. I'm not good at working with js template literal files though. Not sure how we can centralize data in the mock-data directory 😬

@ghost
Copy link

ghost commented Aug 4, 2021

@randallmorey I agree. I'm not good at working with js template literal files though. Not sure how we can centralize data in the mock-data directory 😬

Understood. I'm not sure either! My suggestion isn't urgent. PR approved!

@kaxcode kaxcode merged commit bcd53e7 into main Aug 4, 2021
@kaxcode kaxcode deleted the ui/feature/add-vault-external-source branch August 4, 2021 22:22
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/422224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants