Implements metrics using armon/go-metrics library #1616
Conversation
|
|
Eclion
force-pushed
the
armon-gometrics-implementation
branch
from
7cce0dd
to
9fc25e6
Compare
|
Hello @eikenb ! |
|
Any update on this? Would love to see this merged. We're kind of in the dark now when consul-template fails to render a template. Except when a service using the rendered template eventually breaks, but I would like to know that before hand. |
|
Any updates on this? |
|
+1 for this please. this will go a long way in reliably monitoring consul-template |
There was a problem hiding this comment.
🎉 @Eclion Thank you so much for the thorough work that went into making this PR happen.
Happy to work with you and a few others to get this merged/released within the next couple of weeks.
✍🏾 I did a first pass review and i am leaving a few comments for consideration. Let me know if any of them don't make sense to you.
❓ Do you mind updating this PR to the main branch, looks like it is quite behind now so it will be nice to get this updated before we work on merging it in
🔢 Happy to help/assist in anyway you want me to
Hello @roncodingenthusiast !
Sure! I will rebase my branch before working on your comments.
|
Eclion
force-pushed
the
armon-gometrics-implementation
branch
from
997b530
to
82c33c4
Compare
Eclion
force-pushed
the
armon-gometrics-implementation
branch
from
43166c3
to
80b5f0a
Compare
|
I would very much like for this PR to be merged - and released. Any update on this? |
|
I'm eagerly waiting on this to be merged as well. Can't wait for this to be merged |
Eclion
force-pushed
the
armon-gometrics-implementation
branch
from
750c214
to
011d417
Compare
Eclion
requested review from
a team and
kisunji
and removed request for
a team
implements the metric system following the implementation done in Consul and trying to implement the same metrics as done in the previous metric system (c.f. PR1378: https://github.com/hashicorp/consul-template/pull/1378/files )
following @roncodingenthusiast's suggestion
following @roncodingenthusiast's suggestion
Eclion
force-pushed
the
armon-gometrics-implementation
branch
from
011d417
to
ec189f9
Compare
|
fork rebased on current main branch |
As suggested in the issue #1395, this PR implements a metric system using the armon/go-metrics library along with few metrics.
To achieve such implementation, the metric system was based on the implementation done in Consul and the exposed metrics have been implemented based on the PR #1378.
However, this implementation only partially implements the mentioned metrics:
armon/go-metricslibrary doesn't support yet histograms so these metrics are not implemented in this PR.dependency,configandtelemetrypackages, metrics related to the vault token were not implementedResolves #1395