Manual backport of test: remove unused workflow inputs (#2589) into release/1.1.x #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes proposed in this PR: - Removed unused workflow inputs. Manual backport of b3769b1.
zalimeni
added
pr/no-changelog
curtbushko
approved these changes
Jul 20, 2023
Partial manual backport of e7d528a.
zalimeni
force-pushed
the
zalimeni/fix-backport-pr-test-workflow-1.1.x
branch
from
d3c4b85
to
6965c2b
Compare
|
Force pushed to try a quick cache bust in case that was contributing to
Update: we already have a 5m timeout on |
|
Attempting to resolve cache issues via |
2 tasks
|
Bringing in fix from #2621 to get this to pass (the PRs had a cyclic dependency) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should resolve errors like https://github.com/hashicorp/consul-k8s/actions/runs/5615117399/job/15215290442?pr=2604#step:2:17 due to the missing arg in the target workflow.
Follow-up to #2589.
Checklist: