Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

referencepolicy: finish backwards compatibility support and tests #293

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Jul 19, 2022

Changes proposed in this PR:

How I've tested this PR:

CI tests should still be passing after changes.

How I expect reviewers to test this PR:

Verify changes make sense and sufficiently cover support.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@mikemorris mikemorris changed the title Reference policy compat referencepolicy: finish backwards compatibility support and tests Jul 19, 2022
})
}
refGrants = append(refGrants, refGrant)
refGrants = append(refGrants, gwv1alpha2.ReferenceGrant{Spec: refPolicy.Spec})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests for Gateway CertificateRefs, HTTPRoute, and TCPRoute ReferencePolicy backwards compatibility fail as expected when this line is commented out, so the test coverage gap that existed when #280 was discovered is covered now.

@mikemorris mikemorris added the pr/no-changelog Skip the CI check that requires a changelog entry label Jul 28, 2022
@mikemorris mikemorris requested a review from a team July 28, 2022 17:17
@mikemorris mikemorris marked this pull request as ready for review July 28, 2022 17:17
Copy link
Member

@sarahalsmiller sarahalsmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a point in time when referencepolicy is expected to fail, or will it keep working with the warning indefinitely?

@mikemorris
Copy link
Contributor Author

mikemorris commented Aug 1, 2022

Will there be a point in time when referencepolicy is expected to fail, or will it keep working with the warning indefinitely?

I believe the upstream plan is to remove ReferencePolicy in the next minor (v0.6.0) Gateway API release, so we would likely remove support when upgrading to that - could be several months out though.

@mikemorris mikemorris merged commit f0c759c into main Aug 1, 2022
@mikemorris mikemorris deleted the reference-policy-compat branch August 1, 2022 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/no-changelog Skip the CI check that requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants