Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMRE-177 update to Node20 #53

Merged
merged 4 commits into from
May 8, 2024
Merged

SMRE-177 update to Node20 #53

merged 4 commits into from
May 8, 2024

Conversation

sarahethompson
Copy link
Contributor

@sarahethompson sarahethompson commented May 6, 2024

Summary

tsccr-helper gha update -latest .

https://hashicorp.atlassian.net/browse/SMRE-177?atlOrigin=eyJpIjoiZDZlODI0OGI5ODQ2NGQ0MmEzMTY3MDM0ZDc1ZjFjNzMiLCJwIjoiaiJ9

https://docs.google.com/document/d/1kwq2o70u_WNn-SHxL0zPB94ImMMGHiaEXitMczdx7uQ/edit

Quality

All changes to behavior should be accompanied by relevant tests which both document and protect it.

This PR includes:

  • New or updated tests which validate the new behavior. (Thank you!)
  • New or updated behavior which has been manually tested. (Please provide a link to relevant logs if this is the case.)
  • New or updated behavior which is not testable in a reasonable time frame. (Please ask for help if this is the case, more things are testable than we sometimes think!)
  • No new or changed behavior. (Just documentation, configuration, or pure refactoring.)

@sarahethompson sarahethompson changed the title tsccr-helper gha update -latest . smre-177-node20-update May 6, 2024
@sarahethompson sarahethompson changed the title smre-177-node20-update SMRE-177 update to Node20 May 6, 2024
alvin-huang and others added 3 commits May 7, 2024 12:17
* self-test-suite: make artifact names unique across self-test cases

* self-test-suite: set correct OS used in build artifact names

* self-test-suite-verify: use random ID to distinguish artifacts to upload
@sarahethompson sarahethompson merged commit 37358f6 into main May 8, 2024
70 of 71 checks passed
@sarahethompson sarahethompson deleted the smre-177-node20-update branch May 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants