Skip to content

Commit

Permalink
Revert "Add missing aws-chunked transfer encoding (minio#1803)"
Browse files Browse the repository at this point in the history
This reverts commit 8175bf7.
  • Loading branch information
harshavardhana committed Apr 11, 2023
1 parent 7bf8079 commit a85d829
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/go-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ jobs:
env:
MINT_MODE: core
SERVER_ENDPOINT: localhost:9000
ACCESS_KEY: minio
SECRET_KEY: minio123
ACCESS_KEY: minioadmin
SECRET_KEY: minioadmin
ENABLE_HTTPS: 1
MINIO_KMS_MASTER_KEY: my-minio-key:6368616e676520746869732070617373776f726420746f206120736563726574
MINIO_ACCESS_KEY: minio
MINIO_SECRET_KEY: minio123
MINIO_CI_CD: true
run: |
New-Item -ItemType Directory -Path "$env:temp/certs-dir"
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ jobs:
env:
MINT_MODE: full
SERVER_ENDPOINT: localhost:9000
ACCESS_KEY: minio
SECRET_KEY: minio123
ACCESS_KEY: minioadmin
SECRET_KEY: minioadmin
ENABLE_HTTPS: 1
MINIO_ACCESS_KEY: minio
MINIO_SECRET_KEY: minio123
MINIO_KMS_MASTER_KEY: my-minio-key:6368616e676520746869732070617373776f726420746f206120736563726574
SSL_CERT_FILE: /tmp/certs-dir/public.crt
MINIO_CI_CD: true
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ vet:
${GOPATH}/bin/staticcheck -tests=false -checks="all,-ST1000,-ST1003,-ST1016,-ST1020,-ST1021,-ST1022,-ST1023,-ST1005"

test:
@GO111MODULE=on SERVER_ENDPOINT=localhost:9000 ACCESS_KEY=minio SECRET_KEY=minio123 ENABLE_HTTPS=1 MINT_MODE=full go test -race -v ./...
@GO111MODULE=on SERVER_ENDPOINT=localhost:9000 ACCESS_KEY=minioadmin SECRET_KEY=minioadmin ENABLE_HTTPS=1 MINT_MODE=full go test -race -v ./...

examples:
@echo "Building s3 examples"
Expand All @@ -30,7 +30,7 @@ examples:

functional-test:
@GO111MODULE=on go build -race functional_tests.go
@SERVER_ENDPOINT=localhost:9000 ACCESS_KEY=minio SECRET_KEY=minio123 ENABLE_HTTPS=1 MINT_MODE=full ./functional_tests
@SERVER_ENDPOINT=localhost:9000 ACCESS_KEY=minioadmin SECRET_KEY=minioadmin ENABLE_HTTPS=1 MINT_MODE=full ./functional_tests

clean:
@echo "Cleaning up all the generated files"
Expand Down
2 changes: 1 addition & 1 deletion pkg/signer/request-signature-streaming.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ func prepareStreamingRequest(req *http.Request, sessionToken string, dataLen int
for k := range req.Trailer {
req.Header.Add("X-Amz-Trailer", strings.ToLower(k))
}
req.TransferEncoding = []string{"aws-chunked"}
}
req.TransferEncoding = []string{"aws-chunked"}

if sessionToken != "" {
req.Header.Set("X-Amz-Security-Token", sessionToken)
Expand Down

0 comments on commit a85d829

Please sign in to comment.