[subset-cff] Shorten output of encode_num_tp
#4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you have time to add the tests? Or one of us would need to do that? I think it would be a good idea. |
behdad
reviewed
May 11, 2024
|
I can try to add tests. Should they go in test/api/test-subset-cff2.c or a new file? |
No, keep them easy in |
dscorbett
force-pushed
the
optimize-encode_num_tp
branch
2 times, most recently
from
5ab4c2e
to
1f86f00
Compare
dscorbett
force-pushed
the
optimize-encode_num_tp
branch
from
1f86f00
to
ed030c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes
encode_num_tpto return shorter outputs. It is ported from fonttools/fonttools#3492. The reviewer should be extra careful because, unlike in fontTools, HarfBuzz has no unit tests for this function, and also because I am not fluent in C++.