Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable cache for auth challenge #1645

Merged
merged 2 commits into from Mar 15, 2021
Merged

Conversation

Androbin
Copy link
Contributor

@kblok
Copy link
Member

kblok commented Mar 12, 2021

It seems that the project is not building

@Androbin
Copy link
Contributor Author

@kblok I added the missing assembly references

@Androbin
Copy link
Contributor Author

Androbin commented Mar 15, 2021

The upstream PR got merged 🥳

@kblok
Copy link
Member

kblok commented Mar 15, 2021

Great job on both sides @Androbin!!!

@kblok kblok merged commit caa7adf into hardkoded:master Mar 15, 2021
@Androbin Androbin deleted the proxy-cache branch March 15, 2021 18:54
@Androbin
Copy link
Contributor Author

@kblok Do you have any projections when there will be a new release?

@kblok
Copy link
Member

kblok commented Mar 15, 2021

I'm close here #1640
That will give us PuppeteerSharp 3. Hopefully this week.

@kblok
Copy link
Member

kblok commented Mar 15, 2021

@Androbin do you have spare time to implement the network emulation feature?

@kblok
Copy link
Member

kblok commented Mar 15, 2021

@Androbin this puppeteer/puppeteer#6759 :)

@Androbin
Copy link
Contributor Author

Yea, I think I can do that. I will get right to it.

@Androbin
Copy link
Contributor Author

Androbin commented Mar 15, 2021

Do you keep track of (approximately) which upstream commit / release this project is up to date with?

@kblok
Copy link
Member

kblok commented Mar 15, 2021

I will write a post about the state of puppeteer when I release v3. In a few bullets:

  • We are close to v2.1.1
  • But I'm updating the Chromium revision to the one used in pptr v8. Luckily we are fully compatible with that revision.
  • We will be v3 because I'm changing a few datatypes due to Firefox.

Once we get to v3, I'll create a project to get us straight to v8. That will mean:

  • Having a tool to tells us what are the tests we are missing.
  • Once we have that tool we will know the issues we need to create to take us to v8.

That being said. I would love to keep this project moving, but my time is limited. If you want to jump in and contribute, you will be more than welcome :)

@Androbin
Copy link
Contributor Author

I love a good plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants