Fix formatter and bump ci tools #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
added
the
QA
…/python-can into fix-formatter-and-bump-ci-tools
|
I don't get which change caused the PCAN tests to fail ... |
…cts and the test failure
Codecov Report
@@ Coverage Diff @@
## develop #1167 +/- ##
===========================================
- Coverage 70.81% 70.81% -0.01%
===========================================
Files 79 79
Lines 7738 7737 -1
===========================================
- Hits 5480 5479 -1
Misses 2258 2258 |
hardbyte
approved these changes
Nov 11, 2021
|
Thanks! |
cowo78
pushed a commit
to cowo78/python-can
that referenced
this pull request
Dec 9, 2021
* Bump CI tool versions * Fix many linter issues * Format code with black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, the
blackformatter failed recently. Bumping the version solves this problem (see here).Secondly, bumping the other CI tools made some more changes nessesary. I suppose none of them are really controversial or interesting. As the linters are somehow not executed any more, not all linter issues are fixed by this (there are quite a few that have accumulated).