Replace momentjs by date-fns #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanongil
reviewed
Mar 10, 2021
| ``` | ||
|
|
||
| ## Rules | ||
|
|
||
| ### `date.format(format)` | ||
|
|
||
| Specifies the allowed date format: | ||
| - `format` - string or array of strings that follow the `moment.js` [format](http://momentjs.com/docs/#/parsing/string-format/). | ||
| - `format` - string that follows the `date-fns` [format](https://date-fns.org/v2.19.0/docs/parse). |
There was a problem hiding this comment.
Should probably link to: https://date-fns.org/docs/parse
| method: function (enabled = true) { | ||
|
|
||
| return this.$_setFlag('utc', enabled); | ||
| const date = Parse(value, format, new Date()); |
There was a problem hiding this comment.
Enabling different results depending in the time of invocation does not seem like a good idea.
| @@ -8,27 +8,16 @@ This version requires **joi** v17 or newer. | |||
| const Joi = require('joi') | |||
| .extend(require('@joi/date')); | |||
|
|
|||
| const schema = Joi.date().format('YYYY-MM-DD').utc(); | |||
| const schema = Joi.date().format('YYYY-MM-DD'); | |||
There was a problem hiding this comment.
Bad example, you are parsing 'local week-numbering year' and 'day of a year', which doesn't make sense.
|
|
||
| ```js | ||
| const schema = Joi.date().format(['YYYY/MM/DD', 'DD-MM-YYYY']); | ||
| ``` | ||
| ```js | ||
| const schema = Joi.date().format('YYYY-MM-DD HH:mm'); |
|
I would probably have a look at Luxon, which is a sort of successor to moment: |
|
Or use dayjs instead, the API is much closer I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.