Prevent prototype poisoning in clone(). Closes #352

hapijs · Feb 8, 2020 · 948baf9 · 948baf9
1 parent 0ab1b4f
commit 948baf9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/clone.js b/lib/clone.js
@@ -77,6 +77,10 @@ module.exports = internals.clone = function (obj, options = {}, _seen = null) {
 
     const keys = Utils.keys(obj, options);
     for (const key of keys) {
+        if (key === '__proto__') {
+            continue;
+        }
+
         if (baseProto === Types.array &&
             key === 'length') {
 

diff --git a/test/clone.js b/test/clone.js
@@ -818,7 +818,7 @@ describe('clone()', () => {
 
     it('prevents prototype poisoning', () => {
 
-        const a = JSON.parse('{ "proto": { "x": 1 } }');
+        const a = JSON.parse('{ "__proto__": { "x": 1 } }');
         expect(a.x).to.not.exist();
 
         const b = Hoek.clone(a);