Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use error message as log message for request error logs #159

Merged
merged 1 commit into from Mar 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -147,7 +147,7 @@ async function register (server, options) {
tags: event.tags,
err: event.error
},
'request error'
event.error.message // Will default to `Internal Server Error` by hapi
)
} else if (event.channel === 'app' && !isCustomTagsLoggingIgnored(event, ignoredEventTags.request)) {
logEvent(request.logger, event)
Expand Down
34 changes: 33 additions & 1 deletion test.js
Expand Up @@ -303,7 +303,39 @@ experiment('logs each request', () => {
if (count === 0) {
expect(data.err.message).to.equal('boom')
expect(data.level).to.equal(50)
expect(data.msg).to.equal('request error')
expect(data.msg).to.equal('boom')
} else {
expect(data.res.statusCode).to.equal(500)
expect(data.level).to.equal(30)
expect(data.msg).to.match(/get \/ 500 \(\d*ms\)/)
done()
}
count++
cb()
})
await server.inject('/')
await finish
})

test('handles 500s with no message', async () => {
const server = getServer()
let count = 0
let done
const finish = new Promise(function (resolve, reject) {
done = resolve
})
server.route({
path: '/',
method: 'GET',
handler: (req, reply) => {
throw new Error()
}
})
await registerWithSink(server, 'info', (data, enc, cb) => {
if (count === 0) {
expect(data.err.message).to.equal('Internal Server Error')
expect(data.level).to.equal(50)
expect(data.msg).to.equal('Internal Server Error')
} else {
expect(data.res.statusCode).to.equal(500)
expect(data.level).to.equal(30)
Expand Down