Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tags when errors are logged with server.log() #153

Merged
merged 1 commit into from Feb 1, 2022
Merged

Include tags when errors are logged with server.log() #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Expand Up @@ -119,7 +119,7 @@ async function register (server, options) {
server.events.on('log', function (event) {
if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) { // first check on ignoring tags
if (event.error) {
logger.error({ err: event.error })
logger.error({ err: event.error, tags: event.tags })
} else {
logEvent(logger, event)
}
Expand Down
3 changes: 2 additions & 1 deletion test.js
View file
Open in desktop
Expand Up @@ -426,6 +426,7 @@ experiment('logs through server.log', () => {
})

await tagsWithSink(server, {}, data => {
expect(data.tags).to.equal(['error', 'tag'])
expect(data.err.type).to.equal('Error')
expect(data.err.message).to.equal('foobar')
expect(data.err.stack).to.exist()
Expand All @@ -434,7 +435,7 @@ experiment('logs through server.log', () => {
resolver()
})

server.log(['error'], new Error('foobar'))
server.log(['error', 'tag'], new Error('foobar'))
await done
})

Expand Down