Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read ECONRESET error #145 #149

Merged
merged 4 commits into from Jan 26, 2022
Merged

Fix read ECONRESET error #145 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42e637d
Fix read ECONRESET error #145
aaestrada Nov 24, 2021
136e791
Unit tests: Review ignoredEventTags before process events logs
aaestrada Jan 17, 2022
2ac86f9
Merge branch 'master' into master
aaestrada Jan 19, 2022
207bd4b
log event errors separated of log events
aaestrada Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions index.js
View file
Open in desktop
Expand Up @@ -117,10 +117,12 @@ async function register (server, options) {
})

server.events.on('log', function (event) {
if (event.error) {
logger.error({ tags: event.tags, err: event.error })
} else if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) {
logEvent(logger, event)
if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) { // first check on ignoring tags
if (event.error) {
logger.error({ err: event.error })
} else {
logEvent(logger, event)
}
}
})

Expand Down
3 changes: 1 addition & 2 deletions test.js
View file
Open in desktop
Expand Up @@ -426,7 +426,6 @@ experiment('logs through server.log', () => {
})

await tagsWithSink(server, {}, data => {
expect(data.tags).to.equal(['error', 'tag'])
expect(data.err.type).to.equal('Error')
expect(data.err.message).to.equal('foobar')
expect(data.err.stack).to.exist()
Expand All @@ -435,7 +434,7 @@ experiment('logs through server.log', () => {
resolver()
})

server.log(['error', 'tag'], new Error('foobar'))
server.log(['error'], new Error('foobar'))
await done
})

Expand Down