Skip to content

Commit

Permalink
Include tags when errors are logged with server.log() (#153)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathansamines committed Feb 1, 2022
1 parent d45fcef commit fdf0292
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -119,7 +119,7 @@ async function register (server, options) {
server.events.on('log', function (event) {
if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) { // first check on ignoring tags
if (event.error) {
logger.error({ err: event.error })
logger.error({ err: event.error, tags: event.tags })
} else {
logEvent(logger, event)
}
Expand Down
3 changes: 2 additions & 1 deletion test.js
Expand Up @@ -426,6 +426,7 @@ experiment('logs through server.log', () => {
})

await tagsWithSink(server, {}, data => {
expect(data.tags).to.equal(['error', 'tag'])
expect(data.err.type).to.equal('Error')
expect(data.err.message).to.equal('foobar')
expect(data.err.stack).to.exist()
Expand All @@ -434,7 +435,7 @@ experiment('logs through server.log', () => {
resolver()
})

server.log(['error'], new Error('foobar'))
server.log(['error', 'tag'], new Error('foobar'))
await done
})

Expand Down

0 comments on commit fdf0292

Please sign in to comment.