Fix read ECONRESET error #145 (#149)

* Fix read ECONRESET error #145 * Unit tests: Review ignoredEventTags before process events logs * log event errors separated of log events
hapijs · Jan 26, 2022 · 97a77cb · 97a77cb
1 parent f1af9be
commit 97a77cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -117,10 +117,12 @@ async function register (server, options) {
   })
 
   server.events.on('log', function (event) {
-    if (event.error) {
-      logger.error({ tags: event.tags, err: event.error })
-    } else if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) {
-      logEvent(logger, event)
+    if (!isCustomTagsLoggingIgnored(event, ignoredEventTags.log)) { // first check on ignoring tags
+      if (event.error) {
+        logger.error({ err: event.error })
+      } else {
+        logEvent(logger, event)
+      }
     }
   })
 

diff --git a/test.js b/test.js
@@ -426,7 +426,6 @@ experiment('logs through server.log', () => {
     })
 
     await tagsWithSink(server, {}, data => {
-      expect(data.tags).to.equal(['error', 'tag'])
       expect(data.err.type).to.equal('Error')
       expect(data.err.message).to.equal('foobar')
       expect(data.err.stack).to.exist()
@@ -435,7 +434,7 @@ experiment('logs through server.log', () => {
       resolver()
     })
 
-    server.log(['error', 'tag'], new Error('foobar'))
+    server.log(['error'], new Error('foobar'))
     await done
   })