-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core library bump 6.3.7 #5772
base: master
Are you sure you want to change the base?
Core library bump 6.3.7 #5772
Conversation
New validation requirement as of 2023-09-16
…i-fhir into do-20231213-core-bump-6-2-6
Hi @dotasek and @jamesagnew . Has there been any progress on this PR. |
@heathfrankel This is being actively worked on by several people, but it's nontrivial. David has been leading the work, but there are a number of breaking API changes, and at least one breaking functional validation change that we need to account for before we can land this. Hopefully we'll see this land in the next week or 2. |
@heathfrankel I echo what James has said and I would also suggest that any additional code review would be helpful. |
+ adjust for extra errors.
For 4f491e8 there was a change in the underlying test. The history of this test seems to have waffled back and forth between expected responses, so I referred to the original request: The test uses Edit: On reviewing the original ticket, technically, this is a logical ANY applied to a set, not an AND. I feel like it should be renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus 2 minor things
This is a version bump of the org.hl7.fhir.core library from 6.1.2.2 to 6.3.7.
The trivial changes are matching changing method signatures and class changes.
The more difficult changes revolve around the resource validation. HAPI provides its own implementations of IWorkerContext, which are used by core's InstanceValidator to validate resources.
InstanceValidator has changed significantly with regard to logic, particularly regarding code validation:
org.hl7.fhir.validation/src/main/java/org/hl7/fhir/validation/instance/InstanceValidator.java
See comments for discussion of some of these changes.