[Fix rubocop#3696] modified empty_when lint to not warn when branches…

… when body has comments
hanumakanthvvn · Nov 15, 2016 · 8e71773 · 8e71773
1 parent 5870837
commit 8e71773
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/rubocop/cop/lint/empty_when.rb b/lib/rubocop/cop/lint/empty_when.rb
@@ -15,6 +15,10 @@ module Lint
       class EmptyWhen < Cop
         MSG = 'Avoid `when` branches without a body.'.freeze
 
+        def investigate(processed_source)
+          @processed_source = processed_source
+        end
+
         def on_case(node)
           _cond_node, *when_nodes, _else_node = *node
 

diff --git a/spec/rubocop/cop/lint/empty_when_spec.rb b/spec/rubocop/cop/lint/empty_when_spec.rb
@@ -47,6 +47,13 @@
                      'when :baz',
                      'end'].join("\n")
 
+    it_behaves_like 'code with offense',
+                    ['case foo',
+                     'when :bar then 1',
+                     'when :baz # nothing',
+                     'else',
+                     'end'].join("\n")
+
     it_behaves_like 'code with offense',
                     ['case foo',
                      'when :bar then 1',