-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in colToProp and propToCol methods #7144
Draft
wszymanski
wants to merge
25
commits into
develop
Choose a base branch
from
feature/issue-7031
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f6dac72:
|
…en as argument there is passed visual column index (an integer) #7031
Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>
…eDataAtCell` will not be fixed, `colToProp` will need yet some work #7031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR realise idea to return
null
for indexes beyond the table boundaries while callingpropToCol
method. However, there should be done yet more significant changes which affect lot of places in Handsontable.propToCol
returnsnull
for not existing propertiescolToProp
returnsnull
for indexes beyond the table boundariescolToProp
returnnull
for not existing propertyhandsontable/src/dataMap/dataMap.js
Lines 198 to 201 in 398178d
colToProp
return-1
after handling-1
as argument (considering row header)?colToProp
returnnull
after handling-2
as argument (considering row header)?colToProp
andpropToCol
work on physical indexes (to perform translation also on trimmed indexes properly)?colToProp(number)
andpropToCol(number)
returnnumber
or translated number (to visual/physical index)?colToProp(x) === propToCol(colToProp(x))
?getSourceDataAtCol
,getSourceDataAtCell
andgetAtCell
(internally function) work on physical indexes.