Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to templates README and js template package #10295

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

thilgen
Copy link

@thilgen thilgen commented Mar 19, 2023

Context

  1. examples/templates/README.md
    • Clarified the manual copy instructions
    • Fixed an error in the supplied cp command
  2. examples/templates/js/package.json
    • Attempting to run npm install with a freshly copied version of the js template results in an error
    % npm install
    npm WARN workspaces vanilla-template1 in filter set, but no workspace folder present
    npm WARN deprecated puppeteer@7.1.0: < 19.2.0 is no longer supported
    npm ERR! code 1
    ...
    
    • Fix is to bump up the version of puppeteer to 14.3.0
    • Note: puppeteer:14.3.0 looks to have been in use for all the examples since Handsontable:12.1.0

How has this been tested?

  • Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. n/a

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@adrianszymanski89
Copy link
Contributor

Hi @thilgen

Once again. Thank you for your contribution. We will review your PR as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Docs: remplates README and js template package are incorrect
2 participants