Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Insert row above' while using nestedRows produces Uncaught error when we use it for a first child [Urgent] #7137

Closed
AMBudnik opened this issue Jul 17, 2020 · 3 comments · Fixed by #8720
Assignees

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 17, 2020

Description

'Insert row above' while using nestedRows produces Uncaught error when we use it for a first child.

We have fixed the behavior of using 'Insert row above' but it apparently did not cover this case. If you try to use this option on any other element (parent, nth-child) it works as expected.

Steps to reproduce

  1. Use 'Insert row above' on the Alabama Shakes (2nd row)

Result
The row is not added and you get the console error.
Zrzut ekranu 2020-07-17 o 12 14 44

Demo

https://jsfiddle.net/zo1jhx49/ 7.4.2 (broken)
https://jsfiddle.net/vf4nxou7/ 8.0.0-beta1 (broken)
https://jsfiddle.net/mpdw5t78/ 8.0.0-beta2-rev22 (broken)
https://jsfiddle.net/0bfsrLqp/4/ 8.0.0-rev1 (broken)
https://jsfiddle.net/AMBudnik/08vwazpf/ 8.0.0 (broken)

Your environment

  • Handsontable version: 7.4.2
  • Browser Name and version: Chrome 83
  • Operating System: macOS Catalina 10.15.3

Inform Zen 26480

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Feb 4, 2021

This issue is closed temporarily. It will be reopened for development as it became a part of Interoperability problems between Nested Rows and some core features task reported at #7510

I will make sure to inform everyone interested in this topic after the official fix.

Please feel welcome to makes any comments on this issue. And if you experience similar behavior feel free to contact me at support@handsontable.com

@AMBudnik AMBudnik closed this as completed Feb 4, 2021
@krzysztofspilka krzysztofspilka changed the title 'Insert row above' while using nestedRows produces Uncaught error when we use it for a first child 'Insert row above' while using nestedRows produces Uncaught error when we use it for a first child [Urgent] Aug 23, 2021
@wszymanski wszymanski self-assigned this Sep 14, 2021
wszymanski added a commit that referenced this issue Sep 14, 2021
@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v.10 http://jsfiddle.net/fq34grd6/.

@AMBudnik
Copy link
Contributor Author

Thank you for fixing it. I also did not replicate the issue using v10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants