Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Parent row data is reverted when it's changed between row alteration [Urgent] #8180

Closed
AMBudnik opened this issue Jun 10, 2021 · 5 comments · Fixed by #8703
Closed
Assignees
Labels
bug Nested rows Plugin Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 10, 2021

Description

Parent row data is reverted when it's changed between row alteration.

Steps to reproduce

  1. Right-click any parent row and click on Insert Child Row.
  2. Enter any data on the same parent row.
  3. Again right-click the same parent row and click on Insert Child Row.
  4. Parent row data is reverted

Result
bug

Demo

https://jsfiddle.net/b6qy0h79/ 7.0.0 - works well
https://jsfiddle.net/b6qy0h79/2/ 8.0.0 - first broken
https://jsfiddle.net/Lg13seqo/ - 8.3.2 broken
https://jsfiddle.net/Lg13seqo/1/ - 9.0.0 broken

Your environment

  • Handsontable version: 8.0.0+
  • Browser Name and version: Chrome 91
  • Operating System: Windows 10

Inform Zen 26480 p1.1.

@AMBudnik AMBudnik added bug Nested rows Plugin Regression Issues that were created while adding new changes to the source code labels Jun 10, 2021
@wszymanski wszymanski self-assigned this Aug 18, 2021
@AMBudnik
Copy link
Contributor Author

Scenario 2 - required to work after fix

  • Go to https://jsfiddle.net/4980emLp/
  • Right-click the first parent row “Mix” and choose Insert child row from the context menu.
  • Change Parent item name from “Mix” to “Mix NEW”.
  • Right-click the same parent row “Mix NEW” and choose Insert child row from the context menu.

Result: The parent row changes from “Mix NEW” to “Mix”

bug

@wszymanski
Copy link
Contributor

May be related to #6889.

@krzysztofspilka krzysztofspilka changed the title [8.0.0] Parent row data is reverted when it's changed between row alteration [8.0.0] Parent row data is reverted when it's changed between row alteration [Urgent] Aug 23, 2021
wszymanski added a commit that referenced this issue Sep 6, 2021
wszymanski added a commit that referenced this issue Sep 8, 2021
wszymanski added a commit that referenced this issue Sep 9, 2021
wszymanski added a commit that referenced this issue Sep 9, 2021
@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v10 https://jsfiddle.net/sj9cgfah/
Case 2 https://jsfiddle.net/w2arfv6s/

@AMBudnik
Copy link
Contributor Author

True, works well for my Case 2 as well
https://jsfiddle.net/crvLbdpy/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Nested rows Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants