New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: switch to vendored jsdoc #613

Merged

pinheadmz merged 1 commit into handshake-org:master from pinheadmz:vendor-jsdoc

Jun 17, 2021

Member

pinheadmz commented Jun 16, 2021 •

edited

Needed to prevent CI failures like this one in the future by locking down dependencies that can introduce subtle errors like this.

https://github.com/pinheadmz/bsdoc

https://www.npmjs.com/package/@hns-dev/bsdoc


          ci: switch to vendored jsdoc

31f060f

coveralls commented Jun 16, 2021 •

edited

Pull Request Test Coverage Report for Build 943782642

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 60.736%

Files with Coverage Reduction	New Missed Lines	%
lib/protocol/consensus.js	1	82.79%
lib/script/script.js	1	63.19%

Totals
Change from base Build 936676912:	-0.005%
Covered Lines:	20074
Relevant Lines:	30840

💛 - Coveralls

Falci approved these changes

View reviewed changes

Member

Falci left a comment

No logs from npm audit.

Show Signature

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 31f060f078856bca60d17e4c15e32424aeb9c444
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1BPNxzSHCYYRcK6SAB/zAtFvWsFAmDKTqUACgkQSAB/zAtF
vWuQVRAAhQg8vhWVfZSpUfhHrHzeFiCNk//7byXtjLZo//9gFF/bCobstxCNn0CO
UX52fc1mfZRDReH0FHvtX7AZP8jSVMnVTSZLk4zmGM7tmh6gUmZQL9CfOwsjpBQb
96LFh5fg/0F9L+fLdHAglt+CByNxAVxF09ot+TKZk6emStlocbgh8SD45kQXX0xy
lTo0WkwKXUo/76zIQeIMY2zrSaAGUfDNPPuOxvxUdC6S5ms2HXzpGY6nHNYyPf1S
cvN3Qw8HZrKwSliBeo0i7oxednseKZYyU37jcAKThruN+l4dcAu51g3fJdl6tHd2
0oqN9TFRXlbo6qOJLpIAly+ETs6AvFV5TeKryOLzIga8+SoyF+suWTHgRiHG6j8l
SCmbXxYJ8VmYlxKeiPjqAbaGp+8QC2RyrPQ6M6VpPOMdiWC5bw7Iwmze9l8dF+/C
vzTQWtBIr5JgoJyPxpka1QrMxBsCk50C6NgV6n2tSDyXpg+SpF3qd6QLkEPOTd3u
txKNBN/PRR8syCfgBjRQmVSvrgd8/0AhGmKz7XMQ6tQ0lfN0elg/RyZt7yIPTv7H
2O2KkV/J0Aoe0EcoFIj2juIJNIoBwIJnk8cNftrpAe5QjVmZ8t/Tss1PijEdSgqb
PpvWnuAH+z4DUdzMQpoVnozSlThSlQqHM2E0vvsk8CBQb7Utmv0=
=WLSv
-----END PGP SIGNATURE-----

falci's public key is on keybase

pinheadmz merged commit 98a6491 into handshake-org:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment