Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel and webpack #2005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohd-akram
Copy link
Contributor

@mohd-akram mohd-akram commented Sep 19, 2023

Remove wildcard and require tests since the library has a default export and that's what should be used for browser code.

This is a prerequisite to #2004 and other potential enhancements.

@mohd-akram
Copy link
Contributor Author

Node.js 12, 14 and 16 should be dropped from the CI for pushes and pull requests against master since they're all EOL. They can be kept for pushes and pull requests against the 4.x branch only.

@mohd-akram mohd-akram marked this pull request as ready for review September 19, 2023 21:54
@mohd-akram mohd-akram force-pushed the update-babel-webpack branch 2 times, most recently from 5dbbce0 to 5fcac11 Compare September 20, 2023 12:29
@jaylinski
Copy link
Member

The plan is to use https://github.com/developit/microbundle and get rid of grunt, babel and webpack.

If you wanna give it a try, please go ahead, otherwise please close it and wait for me to make the change.

@mohd-akram
Copy link
Contributor Author

mohd-akram commented Sep 20, 2023

Is it possible to merge this in the meantime until a switch to microbundle is made, since I already have it working with minimal changes and this is a blocker to other improvements. Also, looking at microbundle, it does not seem to be very regularly updated, and I'm not sure how flexible it is. If, for example, we want a bundle with some polyfills (I have a version of this PR for 4.x with all that, but it hit a snag with AMD support). I don't love grunt or babel, and would rip them out too, but that's a more complex endeavor at this point.

EDIT: Apparently it depends on Babel and rollup itself, and quite a few other dependencies.

Remove wildcard and require tests since the library has a default export and
that's what should be used for browser code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants