Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundler issue with webpack 5 #1862

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix bundler issue with webpack 5 #1862

merged 1 commit into from
May 17, 2022

Commits on May 15, 2022

  1. Fix bundler issue with webpack 5 

    As explained in issue #1844 and in issue
webpack/webpack#15007 (comment),
the way we used the `browser`-field was wrong.

The main reason for using the `browser`-field is the requirement of
`require('fs')` in the main-entry-file.
The workaround for this was using `require('handlebars/lib/handlebars')`,
but now it will also work via `require('handlebars')` for bundlers that
respect the `browser`-field.

The `"./runtime"`-config was removed, because it didn't have any effect.
In order to detect regressions, the webpack-integration test was
extended to test with different webpack versions.

Fixes #1174
Closes #1844
    @jaylinski
    jaylinski committed May 15, 2022
    Configuration menu
    Copy the full SHA
    a8261b2 View commit details
    Browse the repository at this point in the history