Replace Saucelabs with Playwright #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaylinski
force-pushed
the
browser-tests
branch
7 times, most recently
from
fcbc1ff
to
6fc5324
Compare
nknapp
reviewed
Dec 4, 2021
There was a problem hiding this comment.
There is a lot of cleanup in this one commit, along with the actual changes. That makes it hard to track the actual changes.
It would be easier to review if there were separate commits in thie PR: One for "renaming and moving stuff", one for "replacing saucelabs with playwright".
Not in this PR anymore...
I left two remarks. Please think about them. Other than that I think the changes are good and the renaming and moving files is beneficial for understanding the project.
We should try to move away from grunt...
First part of reorganizing and cleaning up test-folders.
Second part of reorganizing and cleaning up test-folders.
jaylinski
force-pushed
the
browser-tests
branch
2 times, most recently
from
122427b
to
9c3125d
Compare
Third part of reorganizing and cleaning up test-folders.
jaylinski
force-pushed
the
browser-tests
branch
from
9c3125d
to
9ba7fb8
Compare
Also removed it from published files, since the script doesn't seem to be used. Fourth part of reorganizing and cleaning up test-folders.
Also reorganized npm scripts.
jaylinski
force-pushed
the
browser-tests
branch
4 times, most recently
from
4a25bca
to
1a67625
Compare
jaylinski
force-pushed
the
browser-tests
branch
from
1a67625
to
7716cbd
Compare
@nknapp I split the changes in multiple commits, if you want to take another look. |
nknapp
approved these changes
Dec 23, 2021
nknapp
requested changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reorganized test-folders.