Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport security fixes to 3.x branch #1532

Merged
merged 5 commits into from Jun 29, 2019
Merged

Backport security fixes to 3.x branch #1532

merged 5 commits into from Jun 29, 2019

Commits on Jun 29, 2019

  1. Copy the full SHA
    de6ded4 View commit details
    Browse the repository at this point in the history
  2. Fix build on Windows

    - Handle path-separators properly. Use "path.sep" instead of "/".
      Or use "require.resolve()" if possible
    - Use "execFile" instead of "exec" to run the Handlebars executable.
      This prevents problems due to (missing) shell escaping.
    - Use explicit call to "node" in order to run the executable on Windows.
    - Add "appveyor"-CI in order to run regular tests on Windows.
    nknapp authored and mattolson committed Jun 29, 2019
    Copy the full SHA
    47adcda View commit details
    Browse the repository at this point in the history
  3. test: run appveyor tests in Node 10

    nknapp authored and mattolson committed Jun 29, 2019
    Copy the full SHA
    420ac17 View commit details
    Browse the repository at this point in the history
  4. Use istanbul/lib/cli.js instead of node_modules/.bin/istanbul

    Due to the way, "bin"-files are distributed into the node_modules/.bin
    directory on Windows, the task "test:cov" did not work on Windows.
    This commit uses the node-script directly.
    mattolson committed Jun 29, 2019
    Copy the full SHA
    7820b20 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    7c39440 View commit details
    Browse the repository at this point in the history