New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure caused by yargs #1213

Merged

kpdecker merged 1 commit into handlebars-lang:master from jbboehr:hotfix/yargs-check

May 17, 2016

Contributor

jbboehr commented Apr 21, 2016

In yargs 3.2, any non-truthy return value from check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000
It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86
It appears the build failed for PR #1180, not sure why it was merged


          Fix test failure caused by yargs

f0d4159

In yargs 3.2, any non-truthy return value to check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000
It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86
It appears the build failed for PR #1180, not sure why it was merged

Contributor Author

jbboehr commented May 17, 2016

@kpdecker This issue is in the master branch, so it's causing the Travis builds for all PRs to fail.

kpdecker merged commit 5c9d5b5 into handlebars-lang:master

jbboehr deleted the hotfix/yargs-check branch

May 17, 2016 17:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment