Revert #873 (adding better_errors gem) #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 46de8b1.
|
Hey, sorry for my delay. I know about this problem (check this lightning talk). I think we can introduce simple DNSRebinding middleware for hanami apps for fixing it on our side for all hanami devs. WDYT? I mean something like this: |
davydovanton
approved these changes
Feb 1, 2018
|
👍 so let's merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @igneus for pointing out a security vulnerability in the
better_errorsgem: 46de8b1#commitcomment-26418678It looks like this issue has not been fixed in
better_errors: BetterErrors/better_errors#350