Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify changes to escaping of quotes #918

Merged
merged 1 commit into from May 2, 2017

Conversation

jaredbeck
Copy link
Contributor

@jaredbeck jaredbeck commented May 1, 2017

An example will help people (like me) understand this breaking change.

I think that JSON is a common place where this breaking change will affect people. It caught me. That's why I chose JSON for the example, but maybe a simpler example would be better?

[ci skip]

@k0kubun
Copy link
Member

k0kubun commented May 2, 2017

I couldn't tell from Input: #{JSON.generate(foo: "bar")} whether it's attribute value or script interpolated in plain text. Could you write full Haml literal of attribute?

@jaredbeck
Copy link
Contributor Author

jaredbeck commented May 2, 2017

.. whether it's attribute value or script interpolated in plain text. Could you write full Haml literal of attribute?

It's just ruby inside a :javascript filter. Sorry, I don't know what an "attribute value" is. Do you mean HTML attribute? Sorry, I think you're probably more qualified to write this example than me. :)

@k0kubun
Copy link
Member

k0kubun commented May 2, 2017

Ah okay, you're mentioning a different change.

Escape Ruby script interpolated in filters. (Matt Wildig)

It is #770. What you think is not related with attributes. Please move the section.

An example will help people (like me) understand this breaking
change.

[ci skip]
@jaredbeck jaredbeck force-pushed the clarify_changes_to_escaping branch from 2d47f4d to a4f6081 Compare May 2, 2017 21:09
@jaredbeck
Copy link
Contributor Author

Thanks @k0kubun. Is this better?

Interesting that #770 was merged three years ago. You have been working on haml 5 for a long time! Congratulations :)

@k0kubun
Copy link
Member

k0kubun commented May 2, 2017

Interesting that #770 was merged three years ago. You have been working on haml 5 for a long time!

Yes, indeed.

@k0kubun k0kubun merged commit 2d97f3f into haml:master May 2, 2017
k0kubun added a commit that referenced this pull request May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants