fix error on empty :javascript and :css filter blocks (#986)

Fixes #985.
haml · Mar 10, 2018 · c32fa3c · c32fa3c
1 parent 9856684
commit c32fa3c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/haml/filters.rb b/lib/haml/filters.rb
@@ -182,7 +182,7 @@ def compile(compiler, text)
             return
           end
 
-          rendered = Haml::Helpers::find_and_preserve(filter.render_with_options(text, compiler.options), compiler.options[:preserve])
+          rendered = Haml::Helpers::find_and_preserve(filter.render_with_options(text.to_s, compiler.options), compiler.options[:preserve])
           push_text("#{rendered.rstrip}\n")
         end
       end

diff --git a/test/filters_test.rb b/test/filters_test.rb
@@ -185,6 +185,12 @@ class JavascriptFilterTest < Haml::TestCase
     refute_match('//<![CDATA[', out)
     refute_match('//]]>', out)
   end
+
+  test "should emit tag on empty block" do
+    html = "<script>\n  \n</script>\n"
+    haml = ":javascript"
+    assert_equal(html, render(haml))
+  end
 end
 
 class CSSFilterTest < Haml::TestCase
@@ -224,6 +230,12 @@ class CSSFilterTest < Haml::TestCase
     refute_match('<![CDATA[', out)
     refute_match(']]>', out)
   end
+
+  test "should emit tag on empty block" do
+    html = "<style>\n  \n</style>\n"
+    haml = ":css"
+    assert_equal(html, render(haml))
+  end
 end
 
 class CDATAFilterTest < Haml::TestCase