various: fix miscellaneous typos #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
requested changes
Feb 16, 2024
There was a problem hiding this comment.
For the second, I think I would rather change it to indexes. While indices is absolutely the correct word, I think that indexes will be more understandable to all readers.
Can you also make the following changes:
History.md: Add a short one sentence description of the change here. Remember to include the reference to this PR[#93][]and the appropriate reference link at the bottom of the document.Contributing.md: please add your name to the contributor list.
Once those changes are done, I see no reason not to merge this.
Just as an amusing factoid, the PR title has a typo in it, too.
Signed-off-by: Patrick Linnane <patrick@linnane.io>
p-linnane
force-pushed
the
fix-various-typos
branch
from
106f28f
to
14fad32
Compare
p-linnane
changed the title
|
Changes made as requested. And fixed my own typo as well 😄. |
halostatue
approved these changes
Feb 16, 2024
|
These changes aren't enough to trigger a release, but they will be included in the next one. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix various minor typos across the codebase. I noticed some of these when doing the same review on our Homebrew/brew repo, since we use diff-lcs.