Reintroduce Diff::LCS::Change#to_ary #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knu I believe that this fixes everything. All of the tests pass, but I’d appreciate some additional eyes on this because it is a fairly large change. |
- This required some level of code remediation in the main library, but all
tests now pass:
- Patchsets are now internally flattened one level explicitly, rather than
using Array#flatten. This ensures that only the outer patchset array is
flattened.
Fixes #48.
halostatue
force-pushed
the
flatten-clean-up
branch
from
03977e5
to
efafb8c
Compare
|
Sorry for the delay, I’ll look into this later today! |
|
Looks good, except that I don't really get the idea of a "patchset" yet, but is it a mix of a single Change/ContextChange object or an array of them? |
|
Your reading of 'patchset' is correct; it is an ordered array of changes, where a group of related changes may themselves be an array of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some level of code remediation in the main library, but all
tests now pass:
using Array#flatten. This ensures that only the outer patchset array is
flattened.
Fixes #48.