Skip to content

Commit

Permalink
Add #to_ary to Diff::LCS::Change and Diff::LCS::ContextChange
Browse files Browse the repository at this point in the history
It would be quite handy if you could write as follows:

```ruby
Diff::LCS.sdiff(a, b).each do |action, (old_position, old_element), (new_position, new_element)|
  case action
  when '!'
    # replace
  when '-'
    # delete
  when '+'
    # insert
  end
end
```
  • Loading branch information
knu authored and halostatue committed Jan 26, 2019
1 parent 8b32565 commit 01e0cae
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/diff/lcs/change.rb
Expand Up @@ -41,6 +41,8 @@ def to_a
[ @action, @position, @element ]
end

alias to_ary to_a

def self.from_a(arr)
arr = arr.flatten(1)
case arr.size
Expand Down Expand Up @@ -132,6 +134,8 @@ def to_a
]
end

alias to_ary to_a

def inspect(*args)
to_a.inspect
end
Expand Down
24 changes: 24 additions & 0 deletions spec/change_spec.rb
Expand Up @@ -62,4 +62,28 @@
it { should_not be_finished_a }
it { should be_finished_b }
end

describe "as array" do
it "should be converted" do
action, position, element = described_class.new('!', 0, 'element')
expect(action).to eq '!'
expect(position).to eq 0
expect(element).to eq 'element'
end
end
end

describe Diff::LCS::ContextChange do
describe "as array" do
it "should be converted" do
action, (old_position, old_element), (new_position, new_element) =
described_class.new('!', 1, 'old_element', 2, 'new_element')

expect(action).to eq '!'
expect(old_position).to eq 1
expect(old_element).to eq 'old_element'
expect(new_position).to eq 2
expect(new_element).to eq 'new_element'
end
end
end

0 comments on commit 01e0cae

Please sign in to comment.