Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 #242

Merged
merged 23 commits into from Aug 10, 2018
Merged

Webpack 4 #242

merged 23 commits into from Aug 10, 2018

Conversation

halfzebra
Copy link
Owner

@halfzebra halfzebra commented Mar 20, 2018

This PR enables Webpack 4 support.

CLI

Dev

Dependencies: facebook/create-react-app#4077

While it is possible to update the InterpolateHtmlPlugin and use a temporary replacement, I think it makes sense to wait for CRA release and release CEA with all the updates.

Closes #241

@halfzebra halfzebra changed the title Webpack 4 [Blocked] Webpack 4 Mar 20, 2018
package.json Outdated
"fs-extra": "^5.0.0",
"html-webpack-plugin": "^2.30.1",
"html-webpack-plugin": "^3.0.7cd tem ",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

@halfzebra
Copy link
Owner Author

@pruett thanks for pointing out! Fixed 👍

// if (process.env.NODE_ENV === 'production') { ... }. See `./env.js`.
// It is absolutely essential that NODE_ENV was set to production here.
// Otherwise React will be compiled in the very slow development mode.
new webpack.DefinePlugin(env.stringified),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new webpack.DefinePlugin(env.stringified), is added twice

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@littleStudent
Copy link
Contributor

since facebook/create-react-app#4077 is merged now.
Can this PR move forward? Or are there any other dependencies?

@halfzebra
Copy link
Owner Author

None of the dependencies were released to NPM, the progress can be tracked here facebook/create-react-app#3815

@halfzebra
Copy link
Owner Author

Create Elm App with Webpack 4 is available at npm i create-elm-app@next

Please let me know if you are experiencing any issues!

@halfzebra halfzebra changed the title [Blocked] Webpack 4 Webpack 4 Jun 29, 2018
@halfzebra halfzebra changed the base branch from master to next August 6, 2018 20:47
Upgraded Webpack loaders and fs-extra

BREAKING CHANGE: react-dev-utils is incompatible with the old one, therefore it is containing a
potential breaking change.
Remove the tests for Node 4 and 6

BREAKING CHANGE: Node 4 and 6 are no longer supported.
BREAKING CHANGE: Expected engine major version upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants