Fixing broken CircleCI build #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
fix-circleci-build
branch
2 times, most recently
from
cdf0dd7
to
801dc13
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
fix-circleci-build
branch
from
801dc13
to
bc55871
Compare
hairyhenderson
commented
Oct 14, 2019
| @@ -121,7 +121,7 @@ gen-changelog: | |||
| github_changelog_generator --no-filter-by-milestone --exclude-labels duplicate,question,invalid,wontfix,admin | |||
|
|
|||
| lint: | |||
| golangci-lint run -j $(LINT_PROCS) | |||
| golangci-lint run --disable wsl | |||
There was a problem hiding this comment.
Disabling until bombsimon/wsl#38 is fixed it's fixed (but not downstreamed to golangci-lint yet)
There was a problem hiding this comment.
Ok, until golangci/golangci-lint#811 is fixed 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dave Henderson dhenderson@gmail.com