Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some shellcheck fixes and new input to print Hadolint results to console #68

Merged
merged 2 commits into from Jan 18, 2023
Merged

Conversation

ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Dec 23, 2022

  • few shellcheck fixes
  • added results-to-console input to be able to print results to console
  • added integration testing job to test new input and recursive
  • used env to avoid script injection during integration testing
  • updated documentation

Could be considered as a potential fix of #60

Contains script injection fixes from #62

@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review December 23, 2022 14:07
@ViacheslavKudinov ViacheslavKudinov changed the title Some shellcheck fixes and new input to print results to console Some shellcheck fixes and new input to print Hadolint results to console Dec 23, 2022
@lorenzo
Copy link
Member

lorenzo commented Jan 17, 2023

Thanks for your contribution! would you mind resolving the merge conflicts?

@ViacheslavKudinov
Copy link
Contributor Author

Sure,
I will take a look and update.

@lorenzo lorenzo merged commit 87a23fa into hadolint:master Jan 18, 2023
@lorenzo
Copy link
Member

lorenzo commented Jan 18, 2023

thanks!

@ViacheslavKudinov
Copy link
Contributor Author

ViacheslavKudinov commented Jan 18, 2023

HI @lorenzo
I see that this PR #71 changed behavior and input which I've added a kind of duplication to get output and useless.
But if you can revert my PR merged to master, I can leave only Shellcheck things and remove unnecessary new input.

Or I can create PR by removing input related changes and leaving all other things.

I'm not sure there is a case when someone would like to output the result into some file, but still wants to see it via results-to-console on console 🤔

@lorenzo
Copy link
Member

lorenzo commented Jan 18, 2023

I'll revert

@ViacheslavKudinov
Copy link
Contributor Author

Thanks a lot for the quick revert!
Didn't want to get something useless released when realized the real outcome of another merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants