Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing possible attr errors due to lack of some ast node type-checking (affects only Py3.9+). #162

Merged
merged 5 commits into from Jul 18, 2022
Merged

Fixing possible attr errors due to lack of some ast node type-checking (affects only Py3.9+). #162

merged 5 commits into from Jul 18, 2022

Conversation

hadialqattan
Copy link
Owner

Fixes: #161

@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited

Codecov Report

Merging #162 (41555db) into master (bc48d72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2850      2851    +1     
=========================================
+ Hits          2850      2851    +1
Impacted Files Coverage Δ
tests/test_scan.py 100.00% <ø> (ø)
pycln/utils/scan.py 100.00% <100.00%> (ø)

@hadialqattan hadialqattan mentioned this pull request Jul 18, 2022
Closed
@hadialqattan hadialqattan changed the title (WIP) Fixing Python3.9+ ast changes related bug introduced in v2.0.3. Fixing possible attr errors cause of lacking of some ast node type-checking (affects only Py3.9+). Jul 18, 2022
@hadialqattan hadialqattan changed the title Fixing possible attr errors cause of lacking of some ast node type-checking (affects only Py3.9+). Fixing possible attr errors cause of lack of some ast node type-checking (affects only Py3.9+). Jul 18, 2022
@hadialqattan hadialqattan changed the title Fixing possible attr errors cause of lack of some ast node type-checking (affects only Py3.9+). Fixing possible attr errors due to of lack of some ast node type-checking (affects only Py3.9+). Jul 18, 2022
@hadialqattan hadialqattan changed the title Fixing possible attr errors due to of lack of some ast node type-checking (affects only Py3.9+). Fixing possible attr errors due to lack of some ast node type-checking (affects only Py3.9+). Jul 18, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 18, 2022

Code Climate has analyzed commit 41555db and detected 0 issues on this pull request.

View more on Code Climate.

@hadialqattan hadialqattan merged commit 77feef1 into master Jul 18, 2022
@hadialqattan hadialqattan deleted the i161 branch July 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 2.0.3 update causes 'Tuple' object has no attribute 'value'
1 participant
@hadialqattan