Ignore from ... import * imports in stub files

[AlexWaygood]

Fixes #152. No tests yet, I have no idea what I'm doing there 😅

[hadialqattan]

@AlexWaygood no worries bro, actually, the Refactor._refactor unit tests are very complicated and need refactoring 😅.

[codeclimate]

Code Climate has analyzed commit 8602e84 and detected 0 issues on this pull request.

View more on Code Climate.

[hadialqattan]

@AlexWaygood BTW, I've moved the filetype check to another function avoiding unnecessary scan.expand_import_star calls.

(scan.expand_import_star is considered costy because it includes both pathfinding and static file analysis using scan.ImportablesAnalyzer)

[codecov]

Codecov Report

Merging #153 (8602e84) into master (1a03fde) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2822      2826    +4     
=========================================
+ Hits          2822      2826    +4     

Impacted Files	Coverage Δ
pycln/utils/refactor.py	100.00% <100.00%> (ø)
tests/test_refactor.py	100.00% <100.00%> (ø)

[hadialqattan]

@AlexWaygood I feel that I didn't provide enough context for why I've changed the point where we check for stub files. Please feel free to ask for further clarification.

[AlexWaygood]

@AlexWaygood BTW, I've moved the filetype check to another function avoiding unnecessary scan.expand_import_star calls.

(scan.expand_import_star is considered costy because it includes both pathfinding and static file analysis using scan.ImportablesAnalyzer)

Nice! I tried it out on typeshed again, and can confirm the bug is still fixed :)

[hadialqattan]

@AlexWaygood BTW, I've moved the filetype check to another function avoiding unnecessary scan.expand_import_star calls.
(scan.expand_import_star is considered costy because it includes both pathfinding and static file analysis using scan.ImportablesAnalyzer)

Nice! I tried it out on typeshed again, and can confirm the bug is still fixed :)

Awesome! I'll merge the PR now!

[AlexWaygood]

FYI, typeshed is now using pycln as a pre-commit hook in CI :)

I think it's going to be a big quality-of-life improvement for us!

[hadialqattan]

FYI, typeshed is now using pycln as a pre-commit hook in CI :)

I think it's going to be a big quality-of-life improvement for us!

Awesome! Thanks a lot for supporting Pycln.. btw, I'll add typeshed to the notable projects list that uses pycln!

https://github.com/hadialqattan/pycln#used-by