This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Linalg 4 - Added trait bounded generics as example (not hacspec compliant!) #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added header comments/description - Added matrix type alias - Added repeat function - Changed identity function to better reflect nalgebra
More specifically: - Indexing - Transposition - Slicing - Scaling
| type DimType = usize; | ||
| type Dims = (DimType, DimType); | ||
| type MatRes<T> = Result<Matrix<T>, u8>; | ||
| type ScalRes<T> = Result<T, u8>; |
There was a problem hiding this comment.
This is the type of generics we would need a lot.
| type MatRes<T> = Result<Matrix<T>, u8>; | ||
| type ScalRes<T> = Result<T, u8>; | ||
|
|
||
| pub type Matrix<T> = (Dims, Seq<T>); |
There was a problem hiding this comment.
It would be nice if we could restrict T here for the translation.
| /// Generate a n*m matrix filled with a given scalar. | ||
| pub fn repeat<T>(n: DimType, m: DimType, scalar: T) -> Matrix<T> | ||
| where | ||
| T: hacspec_lib::Integer, |
There was a problem hiding this comment.
I see that we need this here. But it would be nice if we could get away without where clauses.
The question is what is the easiest and tightest bound we could put on T in general here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalized the linear algebra library using trait bounded generics. This should be seen as an example of how traits could eventually be used in hacspec. Feel free to comment/review.