Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork term crate to get windows memory leak fix #5921

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Dec 5, 2018

The term crate creates handles to stdout on windows but the latest released crate does not close them when they go out of scope. There is a merged PR in its master branch that implements drops and plugs this leak.

Unless things change, we should probably migrate our UI code to use the termcolor crate instead. It looks like the term crate is largely unmaintained right now. See Stebalien/term#93:

So, I thought I'd have time to maintain this but then I got a job (where a large portion of said job is maintaining a bunch of OSS projects...). Unfortunately, that leaves me little time (or motivation) to maintain this project.

Signed-off-by: mwrock matt@mattwrock.com

Signed-off-by: mwrock <matt@mattwrock.com>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Contributor

@eeyun eeyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@christophermaier
Copy link
Contributor

Looks like Stebalien/term#63 is the relevant issue.

@eeyun eeyun merged commit 4d551fa into master Dec 5, 2018
chef-ci added a commit that referenced this pull request Dec 5, 2018
Obvious fix; these changes are the result of automation not creative thinking.
@christophermaier christophermaier deleted the conout_handle branch May 4, 2020 17:55
@christophermaier christophermaier added Type:BugFixes PRs that fix an existing bug Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Platform: Windows Deals with Windows-specific behavior Type: Bug Issues that describe broken functionality and removed X-fix labels Jul 24, 2020
@Izian4321
Copy link

hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Platform: Windows Deals with Windows-specific behavior Type: Bug Issues that describe broken functionality Type:BugFixes PRs that fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants