fork term crate to get windows memory leak fix #5921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
term
crate creates handles to stdout on windows but the latest released crate does not close them when they go out of scope. There is a merged PR in its master branch that implements drops and plugs this leak.Unless things change, we should probably migrate our UI code to use the
termcolor
crate instead. It looks like theterm
crate is largely unmaintained right now. See Stebalien/term#93:Signed-off-by: mwrock matt@mattwrock.com