Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #2046

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 7, 2022

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (25c55e5) to head (5b3576b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files          17       17           
  Lines        2391     2391           
=======================================
  Hits         2142     2142           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takluyver
Copy link
Member

@takluyver
Copy link
Member

The only way to make the newer version of check-manifest work is to duplicate some of the build dependencies in .pre-commit-config.yaml, so they can be installed before the hook runs. That's particularly silly because we don't actually need most/any of them to build an sdist (which check-manifest does), but the static list of build requirements in pyproject.toml doesn't distinguish between requirements for making an sdist and requirements for compiling the code and making a wheel.

So IDK if this is better than just sticking to the old version. 🤷 I hope that it will be nicer once we can use a build backend based on Meson or CMake or something.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 22568da to c30dc01 Compare March 7, 2022 19:49
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c30dc01 to 06ccbd8 Compare April 4, 2022 19:30
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 06ccbd8 to 212f479 Compare May 2, 2022 19:43
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 212f479 to 9922d60 Compare July 4, 2022 20:54
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.1.0...v4.6.0)
- [github.com/mgedmin/check-manifest: 0.39 → 0.49](mgedmin/check-manifest@0.39...0.49)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 17ce5c4 to 5b3576b Compare May 6, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant