Implemented H5DOappend #1891
Open
Implemented H5DOappend #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 17 17
Lines 2278 2278
=======================================
Hits 2015 2015
Misses 263 263 Continue to review full report at Codecov.
|
tacaswell
reviewed
Jun 21, 2021
| """ | ||
| @ut.skipIf( | ||
| h5py.version.hdf5_version_tuple < (1, 10, 0), | ||
| "Reading non-existent label segfaults" |
|
@bomber8013 Can you expand on "Reading non-existent label segfaults"? It would be nice to merge this. |
|
Wow, apparently I'm pretty bad at following up. This was because H5DOappend was added in 1.10.0 of HDF5. I might need to change the test of why it's being skipped? Also I thought this feature was undesirable since we didn't want to add the optimized functions/library as a required component for h5py? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented H5DOappend by adding the C function to the API list and adding append function to h5d.pyx. Implemented and passed tests and added contribution note.
Closes #1890