Make file closing and get_obj_ids more robust #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preventing IDs from being dec_ref-ed to 0 between retrieving them and inc_ref-ing them. Closes h5pygh-1852
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 88.40% 87.28% -1.13%
==========================================
Files 17 17
Lines 2285 2178 -107
==========================================
- Hits 2020 1901 -119
- Misses 265 277 +12
Continue to review full report at Codecov.
|
takluyver
changed the title
h5f.get_obj_ids
|
I can confirm that this also makes the issue go away for the other reproducers I'm aware of. |
|
Is there a rough timeline on when a version with this will be released? |
|
Sorry for the delay. Things seem to have gone quiet, which hopefully means 3.2.1 is working OK for most people. But I'll try to do a new release some time soon. I would like to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now contains two related changes.
First, temporarily disable garbage collection in
h5py.h5f.get_obj_ids, so it can't invalidate HDF5 IDs between us retrieving them and callingH5Iinc_refto keep them alive. This fixes #1852.However,
get_obj_idsis still a fairly awkward thing to call fromFile.close()- it creates h5py ObjectID objects, which can cause problems at interpreter shutdown, and it increments HDF5 ref counts only to decrement them again. Now it also has to turn garbage collection off and on again. So I moved part of theFile.closelogic into aFileID._close_open_objectsmethod, which calls the autogenerated bindings directly and avoids these complexities. This fixes #1495.